ADD: Like button system test #7252

VladimirMikulic · 2020-01-15T20:42:46Z

Part of #5316

@Uzay-G could you take a look at this? Thanks.

codecov · 2020-01-15T20:54:40Z

Codecov Report

Merging #7252 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7252   +/-   ##
=======================================
  Coverage   81.59%   81.59%           
=======================================
  Files          97       97           
  Lines        5601     5601           
=======================================
  Hits         4570     4570           
  Misses       1031     1031

Uzay-G · 2020-01-15T20:55:52Z

@VladimirMikulic I am busy right now but will check it out in 20 mins. It look good 👍

test/system/post_test.rb

SidharthBansal · 2020-01-16T09:05:35Z

I will review after Uzay reviews it. Kind of busy with lunch.

…

On Thu, 16 Jan 2020, 1:50 pm Vladimir Mikulic, ***@***.***> wrote: @VladimirMikulic <https://github.com/VladimirMikulic> requested your review on: #7252 <#7252> ADD: Like button system test. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#7252?email_source=notifications&email_token=AFAAEQ35N33MKAZPIT6KQV3Q6AKDLA5CNFSM4KHJTKPKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWAGBMEI#event-2953582097>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQYQUWZKG5GWJH6LBC3Q6AKDLANCNFSM4KHJTKPA> .

Uzay-G

Yeah this is good! Maybe we could add a check to verify that the number of likes changes when the page is reloaded. I had written the test for this and I would love to hear what you think. I will post it when I get home in a few hours

SidharthBansal · 2020-01-16T17:02:08Z

You can write more tests. We can evaluate marks after merging all the prs. @Uzay-G I can't see your system tests prs. It will be great if you can start with system tests too. Thanks both

Uzay-G · 2020-01-16T19:57:19Z

You can write more tests. We can evaluate marks after merging all the prs. @Uzay-G I can't see your system tests prs. It will be great if you can start with system tests too. Thanks both

I have one at #7254 and another one was merged at #7251

Part of #5316

jywarren · 2020-01-17T02:03:48Z

Trying to bypass the codecov issue...

SidharthBansal · 2020-01-17T03:25:40Z

System test 2 task's test 1. Trying to get 4 more tasks to get your system test 2 approved too

VladimirMikulic · 2020-01-17T03:26:17Z

@SidharthBansal you can count on me :)

SidharthBansal · 2020-01-17T03:28:06Z

Yeah I am counting you. Policies are same for all students. Sorry if anything unfair or anything wrong I did

VladimirMikulic · 2020-01-17T03:36:38Z

Why are you apologising? You are one of the best mentors of this GCI.
Let's be real you were with us even when you were on vacation and while you had a fever...

I appreciate that very much and I apologise if I had said something wrong or did something wrong.

SidharthBansal · 2020-01-17T05:13:16Z

I just thought you felt that I am not treating all the gci students equally. You have not done anything wrong :-)

SidharthBansal · 2020-01-17T05:14:08Z

You all are really hardworking. If I was that much hardworking at your age then I would be in the skies today. :-)

VladimirMikulic · 2020-01-17T06:55:07Z

You are a Google Tech Intern. It means that you are hardworking.

Uzay-G · 2020-01-17T07:15:47Z

This is a nice thread! Thanks for mentoring us @SidharthBansal. I will get started on all the issues you mentioned this weekend once I have more time 👍

…

On Fri, Jan 17, 2020, 07:55 Vladimir Mikulic ***@***.***> wrote: You are a Google Tech Intern. It means that you are hardworking. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7252?email_source=notifications&email_token=AMTREYOOTHWKYCFEN7CVQK3Q6FI4XA5CNFSM4KHJTKPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGW3JI#issuecomment-575499685>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMTREYIAQKWL4KUWTKFWO2TQ6FI4XANCNFSM4KHJTKPA> .

SidharthBansal · 2020-01-17T09:01:42Z

I was. I was rejected there.

…

On Fri, 17 Jan 2020, 12:45 pm Uzay-G, ***@***.***> wrote: This is a nice thread! Thanks for mentoring us @SidharthBansal. I will get started on all the issues you mentioned this weekend once I have more time 👍 On Fri, Jan 17, 2020, 07:55 Vladimir Mikulic ***@***.***> wrote: > You are a Google Tech Intern. It means that you are hardworking. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #7252?email_source=notifications&email_token=AMTREYOOTHWKYCFEN7CVQK3Q6FI4XA5CNFSM4KHJTKPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGW3JI#issuecomment-575499685 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AMTREYIAQKWL4KUWTKFWO2TQ6FI4XANCNFSM4KHJTKPA > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7252?email_source=notifications&email_token=AFAAEQ5NQCZ6ANHOD3XDV3DQ6FLKHA5CNFSM4KHJTKPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGYE2I#issuecomment-575505001>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ5623PUSTQ43IEO2ADQ6FLKHANCNFSM4KHJTKPA> .

VladimirMikulic · 2020-01-17T15:41:39Z

@SidharthBansal I completely agree with @Uzay-G.
You really have great $ uptime and you should be proud of yourself :)
I've learned a lot of great things from you.

SidharthBansal · 2020-01-17T15:47:59Z

Thanks

jywarren · 2020-01-17T15:57:29Z

sending ❤️ for this convo! 🎉

SidharthBansal · 2020-01-17T16:11:45Z

Let's complete System tests this GCI.
I was thinking of Project-Based Mentorship in GCI which I proposed #3285 but there was not wide momentum at that time. Last year, @jywarren we did the log in modal and this year we are doing System Tests through this. I think we should reopen this issue and escalate the discussion.
The advantages are HUGE. The problem is simple. We require DEDICATED MENTORSHIP. One ongoing work is Code-based rights. When we will club these two things (Project based DEDICATED Mentorship in GCI + Code Based rights(#7271)), the GCI ladder will be better than GSoC ladder. Also, I will say, it could result in early talent hunting for Public Lab.
If you think we can go with #3285 from next GCI, we can plan in that direction too in February. Please feel free to reopen the issue.

Suggestions needed
Thanks
Sidharth

VladimirMikulic · 2020-01-17T16:24:18Z

Wow, it is a really cool idea. We should first define what needs to be done and then split it into smaller issues.

SidharthBansal · 2020-01-17T16:25:53Z

This is a really EPIC thing to discuss. I will escalate it at the end of GCI

Part of publiclab#5316

Uzay-G reviewed Jan 15, 2020

View reviewed changes

test/system/post_test.rb Show resolved Hide resolved

VladimirMikulic requested a review from SidharthBansal January 16, 2020 08:20

Uzay-G reviewed Jan 16, 2020

View reviewed changes

VladimirMikulic requested a review from jywarren January 16, 2020 22:25

ADD: Like button system test

44ce855

Part of #5316

jywarren mentioned this pull request Jan 17, 2020

Brainstorm a list of critical full-stack system tests we should add #5316

Closed

13 tasks

jywarren closed this Jan 17, 2020

jywarren reopened this Jan 17, 2020

SidharthBansal approved these changes Jan 17, 2020

View reviewed changes

SidharthBansal merged commit e15a4dd into publiclab:master Jan 17, 2020

vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020

ADD: Like button system test (publiclab#7252)

f94c92c

Part of publiclab#5316

NitinBhasneria pushed a commit to NitinBhasneria/plots2 that referenced this pull request Feb 5, 2020

ADD: Like button system test (publiclab#7252)

4115a31

Part of publiclab#5316

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADD: Like button system test #7252

ADD: Like button system test #7252

VladimirMikulic commented Jan 15, 2020

codecov bot commented Jan 15, 2020 •

edited

Loading

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 16, 2020 via email

Uzay-G left a comment

SidharthBansal commented Jan 16, 2020

Uzay-G commented Jan 16, 2020

jywarren commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020 •

edited

Loading

SidharthBansal commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020 •

edited

Loading

VladimirMikulic commented Jan 17, 2020

Uzay-G commented Jan 17, 2020 via email

SidharthBansal commented Jan 17, 2020 via email

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

jywarren commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

ADD: Like button system test #7252

ADD: Like button system test #7252

Conversation

VladimirMikulic commented Jan 15, 2020

codecov bot commented Jan 15, 2020 • edited Loading

Codecov Report

Uzay-G commented Jan 15, 2020

SidharthBansal commented Jan 16, 2020 via email

Uzay-G left a comment

Choose a reason for hiding this comment

SidharthBansal commented Jan 16, 2020

Uzay-G commented Jan 16, 2020

jywarren commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020 • edited Loading

SidharthBansal commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020 • edited Loading

VladimirMikulic commented Jan 17, 2020

Uzay-G commented Jan 17, 2020 via email

SidharthBansal commented Jan 17, 2020 via email

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

jywarren commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

VladimirMikulic commented Jan 17, 2020

SidharthBansal commented Jan 17, 2020

codecov bot commented Jan 15, 2020 •

edited

Loading

VladimirMikulic commented Jan 17, 2020 •

edited

Loading

SidharthBansal commented Jan 17, 2020 •

edited

Loading