Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: system tests for wiki edits #7254

Merged
merged 2 commits into from
Jan 16, 2020
Merged

ADD: system tests for wiki edits #7254

merged 2 commits into from
Jan 16, 2020

Conversation

Uzay-G
Copy link
Member

@Uzay-G Uzay-G commented Jan 15, 2020

For part of #5316

I added a test that verifies that users can edit wikis and preview their contents. What do you think @VladimirMikulic?

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my server, the test fails. Let's wait for Travis though.

@Uzay-G
Copy link
Member Author

Uzay-G commented Jan 15, 2020

On my server, the test fails. Let's wait for Travis though.

This is weird. It is working for me...

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #7254 into master will decrease coverage by 4.86%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7254      +/-   ##
==========================================
- Coverage   81.53%   76.66%   -4.87%     
==========================================
  Files          97       97              
  Lines        5599     5705     +106     
==========================================
- Hits         4565     4374     -191     
- Misses       1034     1331     +297
Impacted Files Coverage Δ
app/controllers/users_controller.rb 70.42% <ø> (-10.57%) ⬇️
app/mailers/admin_mailer.rb 100% <100%> (ø) ⬆️
app/models/concerns/node_shared.rb 90.29% <100%> (ø) ⬆️
app/controllers/openid_controller.rb 0% <0%> (-53.85%) ⬇️
app/controllers/comment_controller.rb 72.34% <0%> (-14.9%) ⬇️
app/models/comment.rb 68.57% <0%> (-8.22%) ⬇️
app/controllers/application_controller.rb 84.74% <0%> (-7.63%) ⬇️
app/controllers/home_controller.rb 91.93% <0%> (-6.46%) ⬇️
app/controllers/admin_controller.rb 71.84% <0%> (-6.31%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299a6f4...d7aa7cd. Read the comment docs.

@Uzay-G
Copy link
Member Author

Uzay-G commented Jan 15, 2020

There were differences between my fork and this repo. I need to find a way to select the edit button for the wiki. I will work on this tomorrow!

@VladimirMikulic
Copy link
Contributor

VladimirMikulic commented Jan 15, 2020

@Uzay-G this will make your test work:

find('.like-buttons a.btn-circle:first-of-type .fa-pencil').click()

100% precision :)

@Uzay-G
Copy link
Member Author

Uzay-G commented Jan 16, 2020

@Uzay-G this will make your test work:

find('.like-buttons a.btn-circle:first-of-type .fa-pencil').click()

100% precision :)

Thanks! I will try it out 👍

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!!!

@jywarren jywarren merged commit 03ac17f into publiclab:master Jan 16, 2020
@SidharthBansal
Copy link
Member

4th test here

vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
* add system tests for wiki edits

* fix selector
NitinBhasneria pushed a commit to NitinBhasneria/plots2 that referenced this pull request Feb 5, 2020
* add system tests for wiki edits

* fix selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants