ADD: System test for comments

[Uzay-G]

For part of #5316.

I have added a system test for commenting on a note. The test verifies that the UI reacts properly to the comment and that the preview button works well.

Are there any other comment tests you think would be useful? What do you think @VladimirMikulic @publiclab/reviewers?

[VladimirMikulic]

Nice one @Uzay-G. The test fails on my server, we'll see what Travis says.

[Uzay-G]

Yeah you are right. There is a problem I hadn't noticed. I will fix it 👍

[codecov]

Codecov Report

Merging #7251 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #7251      +/-   ##
=========================================
- Coverage   81.53%   81.4%   -0.13%     
=========================================
  Files          97      97              
  Lines        5599    5599              
=========================================
- Hits         4565    4558       -7     
- Misses       1034    1041       +7

Impacted Files	Coverage Δ
app/services/execute_search.rb	88.88% <0%> (-5.56%)	⬇️
app/api/srch/search.rb	64.7% <0%> (-3.93%)	⬇️

[Uzay-G]

Alright I fixed it. I also refactored things to a setup method that will login before each test instead of putting the commands in the tests each time.

[Uzay-G]

Does this work for you @VladimirMikulic?

[VladimirMikulic]

Yes, it does!!!

[SidharthBansal]

You both have to complete tests for 6 features. Then I will approve tasks for both of you. And you both will get 15 points each. After that we can repeat this activity as many times as you want. I hope this will give you a lot of points and learning too

…

On Thu, 16 Jan 2020, 1:59 am plotsbot, ***@***.***> wrote: 1 Warning ⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml 2 Messages 📖 @Uzay-G <https://github.com/Uzay-G> Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And *don’t be discouraged if you see errors* – we’re here to help. 📖 # Screenshots 📸 (click to expand)7251-test_questions.png <https://camo.githubusercontent.com/efbbe09b1b16260f96f47f0918f4647779347bfb/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7175657374696f6e732e706e67> 7251-test_embeddable_grids.png <https://camo.githubusercontent.com/000e84ce75bdcb585f53a97d6a9f98b3a1fc5785/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f656d6265646461626c655f67726964732e706e67> 7251-test_signup.png <https://camo.githubusercontent.com/b2bf4ffc5751841d94fa321cfbee3051faaba511/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7369676e75702e706e67> 7251-test_viewing_the_settings_page.png <https://camo.githubusercontent.com/9fa506a1ca27ada4ace25dc5a576ef5cf5e2966c/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f76696577696e675f7468655f73657474696e67735f706167652e706e67> 7251-test_tag_by_author_page.png <https://camo.githubusercontent.com/72a4c8ea907ba42f93992f5ed1ca4ebeb96f9d40/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7461675f62795f617574686f725f706167652e706e67> 7251-test_wiki_page_with_inline_grids.png <https://camo.githubusercontent.com/b88214b617a1e0471ca672e8897831eb588e5da9/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f77696b695f706167655f776974685f696e6c696e655f67726964732e706e67> 7251-test_stats.png <https://camo.githubusercontent.com/c3dd08475ed00e65c40e60504823c8c65da671b6/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f73746174732e706e67> 7251-test_viewing_the_dashboard.png <https://camo.githubusercontent.com/169a04cfd23c20e70d59a1325c2f298a45208bdf/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f76696577696e675f7468655f64617368626f6172642e706e67> 7251-test_searching_an_item_from_the_homepage.png <https://camo.githubusercontent.com/835da4c734219d1b3eb859e647e567d9a943a51e/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f736561726368696e675f616e5f6974656d5f66726f6d5f7468655f686f6d65706167652e706e67> 7251-test_signup_modal_form_validation.png <https://camo.githubusercontent.com/4a95c6bddb776dd9024ad70745c7aba4f15e7882/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7369676e75705f6d6f64616c5f666f726d5f76616c69646174696f6e2e706e67> 7251-test_tag_stats.png <https://camo.githubusercontent.com/657e5a6ff8e94de35a2f14f1d228b9371c96bcf5/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7461675f73746174732e706e67> 7251-test_login_modal_form_validation.png <https://camo.githubusercontent.com/facc5dce28616e6183d0cb873146e0e127037e90/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f6c6f67696e5f6d6f64616c5f666f726d5f76616c69646174696f6e2e706e67> 7251-test_questions_shadow.png <https://camo.githubusercontent.com/5070ffac73c99a92a63627ae50a5a124bc6082d1/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7175657374696f6e735f736861646f772e706e67> 7251-test_login_modal.png <https://camo.githubusercontent.com/549763877d7bddbb05bd7db8a878b4414b913e7d/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f6c6f67696e5f6d6f64616c2e706e67> 7251-test_profile_page.png <https://camo.githubusercontent.com/9e0c5362a704da241d5f245483cb5e4610ef0ace/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f70726f66696c655f706167652e706e67> 7251-test_comments.png <https://camo.githubusercontent.com/b31305c3888afeafafdea65768f7f64cca127b5a/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f636f6d6d656e74732e706e67> 7251-test_tags.png <https://camo.githubusercontent.com/b7e4668582fc4e1d6d78a4fdaf97bc066b30c9a0/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f746167732e706e67> 7251-test_signup_modal.png <https://camo.githubusercontent.com/8656a2910806ba09b8c0ee54d2d44790cb9c5cc2/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7369676e75705f6d6f64616c2e706e67> 7251-test_wiki.png <https://camo.githubusercontent.com/ab746820ca9e4f383be416b037be072ad8f5dc0a/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f77696b692e706e67> 7251-test_methods.png <https://camo.githubusercontent.com/1b9b6846e64dc03d5abb177acbfc4801eb885acf/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f6d6574686f64732e706e67> 7251-test_tag_page.png <https://camo.githubusercontent.com/9896cf9b81b354675c333b7f823f2323858d193e/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7461675f706167652e706e67> 7251-test_blog_page_with_location_modal.png <https://camo.githubusercontent.com/1e4b94470107419713616ff5b16063c888b9b7d7/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f626c6f675f706167655f776974685f6c6f636174696f6e5f6d6f64616c2e706e67> 7251-test_tag_wildcard.png <https://camo.githubusercontent.com/7f4e5227303b5fd95e3e937493d8c7db1d30f417/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7461675f77696c64636172642e706e67> 7251-test_signup_modal_disabled_submit_button_on_empty_username.png <https://camo.githubusercontent.com/e1db41aad156da43b4a477175484170a8f84acc2/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7369676e75705f6d6f64616c5f64697361626c65645f7375626d69745f627574746f6e5f6f6e5f656d7074795f757365726e616d652e706e67> 7251-test_embeddable_thumbnail_grids.png <https://camo.githubusercontent.com/18f03a4bb1c01b6d9d6a1d617106ad1237b58aa2/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f656d6265646461626c655f7468756d626e61696c5f67726964732e706e67> 7251-test_front_page_with_navbar_search_autocomplete.png <https://camo.githubusercontent.com/6ad8cdb8d3ced5573e566c1e60d7e5f64208765d/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f66726f6e745f706167655f776974685f6e61766261725f7365617263685f6175746f636f6d706c6574652e706e67> 7251-test_spam_moderation_page.png <https://camo.githubusercontent.com/13264e40b35a9d17df3b197f3ec737ea968a3d85/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7370616d5f6d6f6465726174696f6e5f706167652e706e67> 7251-test_login.png <https://camo.githubusercontent.com/7a0c9de341955fb28087d1ded9a75bb6c556861d/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f6c6f67696e2e706e67> 7251-test_viewing_the_dropdown_menu.png <https://camo.githubusercontent.com/d024a55eaa67cc74c8991e4c61e8ebfd2c669510/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f76696577696e675f7468655f64726f70646f776e5f6d656e752e706e67> 7251-test_viewing_question_post.png <https://camo.githubusercontent.com/44f6f91a95ce6c0a2f0a8f4141536e9f8c6ab178/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f76696577696e675f7175657374696f6e5f706f73742e706e67> 7251-test_mobile_displays.png <https://camo.githubusercontent.com/107b566693094c190a98fc6c1b80a855a2823138/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f6d6f62696c655f646973706c6179732e706e67> 7251-test_simple-data-grapher_powertag.png <https://camo.githubusercontent.com/1a49c0155b7a28e537ac5a5ed0844c595180406c/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f73696d706c652d646174612d677261706865725f706f7765727461672e706e67> 7251-test_front.png <https://camo.githubusercontent.com/e6374d6790a1bb6208c0a913826729cd53f3ae17/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f66726f6e742e706e67> 7251-test_question_page.png <https://camo.githubusercontent.com/fa4f1b94ce41dbd46ac2f40ecd229762946f5f9d/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7175657374696f6e5f706167652e706e67> 7251-test_tag_contributors_page.png <https://camo.githubusercontent.com/7fe9afca6680b4e3d10c4d7a529ddf1f20f0616b/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f7461675f636f6e7472696275746f72735f706167652e706e67> 7251-test_blog.png <https://camo.githubusercontent.com/e7532baf396a101df3f46d8c737af5e1e0649f8f/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f626c6f672e706e67> 7251-test_people.png <https://camo.githubusercontent.com/446c1b0777b0db116895c772ee5866dfdd1f4a9a/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f70656f706c652e706e67> 7251-test_wiki_revisions.png <https://camo.githubusercontent.com/6b01474f36b17a191a01cca1a3649f87f4796d5a/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f706c6f7473322d73637265656e73686f74732f373235312d746573745f77696b695f7265766973696f6e732e706e67> Learn about automated screenshots <#5316> Generated by 🚫 Danger <https://danger.systems/> — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#7251?email_source=notifications&email_token=AFAAEQ22AWZD73STR57VXQLQ55W2NA5CNFSM4KHI7AE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBWNJI#issuecomment-574842533>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQZTSERKHI5ER2UIYWLQ55W2NANCNFSM4KHI7AEQ> .

[VladimirMikulic]

@SidharthBansal it will for sure :)

[jywarren]

This is great, and I'll merge it now -- i wonder if we can make a more complex one, where there are multiple comment fields on the page, and we ensure it enters the comment in the correct one (like, a response vs. a comment). What do you think?

[jywarren]

Thank you!!!!

[Uzay-G]

This is great, and I'll merge it now -- i wonder if we can make a more complex one, where there are multiple comment fields on the page, and we ensure it enters the comment in the correct one (like, a response vs. a comment). What do you think?

Yeah that could be interesting. I will think about what we could do 👍

[SidharthBansal]

5th test here
We just need to approve at the GCI dashboard now