Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Priority)Search Bug #769

Closed
sashadev-sky opened this issue Jul 1, 2019 · 7 comments · Fixed by #785
Closed

(Priority)Search Bug #769

sashadev-sky opened this issue Jul 1, 2019 · 7 comments · Fixed by #785

Comments

@sashadev-sky
Copy link
Member

What happened just before the problem occurred

Some backend search constraints were implemented in #630 by me which cut out some extra database queries if your search query is less than 3 characters long.

Since then the entire UI has been updated - but if you make any query it re-renders the old UI and you can't get back to the new one:

search constraint2

Less priority -
Was initially going to open this issue to say constraint performance could be improved on a lot by adding frontend JS constraints - because currently a query less than 3 chars long still causes a page reload.

Relevant URLs

https://

PublicLab.org username

(to help reproduce the issue)

Browser, version, and operating system

For bug reports, fill out the above template; for feature requests, you can delete the template.

@sashadev-sky
Copy link
Member Author

@divyabaid16 @jywarren @gauravano @avsingh999

Sorry if this isn't priority feel free to remove that header but I think its a pretty significant bug

@grvsachdeva
Copy link
Member

The production doesn't have this issue as that PR is not pushed to stable yet, so I think we can remove the priority keyword. Or, lets just fix it, as we don't need to wait for a PR to break things.

Running localhost to observe the interface closely. Thanks, @sashadev-sky for reporting.

@grvsachdeva
Copy link
Member

Hmm, so how exactly we want our search page to look? I think sidebar needs work so as to follow the updated template?

@jywarren
Copy link
Member

jywarren commented Jul 1, 2019

Ah, ok - so this may be priority because I'm really hoping to publish main to the live site today or tomorrow... i'm working on some other optimizations and display changes, so if anyone else can try this that'd be great. I believe we now have templates at /gallery that could be used to show results? Thanks for the catch!

@cesswairimu
Copy link
Collaborator

Hey all, do we want this search to be available on the front-page(if so how do we display this or should it be a redirect to gallery page?) or show I make it only available on the gallery page? Wonna hear your thoughts. Thanks

@jywarren
Copy link
Member

jywarren commented Jul 2, 2019 via email

@cesswairimu
Copy link
Collaborator

Guess so...looking into it. Thanks Jeff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants