-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Priority)Search Bug #769
Comments
@divyabaid16 @jywarren @gauravano @avsingh999 Sorry if this isn't priority feel free to remove that header but I think its a pretty significant bug |
The production doesn't have this issue as that PR is not pushed to stable yet, so I think we can remove the priority keyword. Or, lets just fix it, as we don't need to wait for a PR to break things. Running localhost to observe the interface closely. Thanks, @sashadev-sky for reporting. |
Hmm, so how exactly we want our search page to look? I think sidebar needs work so as to follow the updated template? |
Ah, ok - so this may be priority because I'm really hoping to publish |
Hey all, do we want this search to be available on the front-page(if so how do we display this or should it be a redirect to gallery page?) or show I make it only available on the gallery page? Wonna hear your thoughts. Thanks |
Let's have the search from any page (via navbar) direct to the gallery
template, but retain the current URL schemes -- can that work?
…On Tue, Jul 2, 2019 at 2:34 PM Cess ***@***.***> wrote:
Hey all, do we want this search to be available on the front-page(if so
how do we display this or should it be a redirect to gallery page?) or show
I make it only available on the gallery page? Wonna hear your thoughts.
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#769?email_source=notifications&email_token=AAAF6J7LIB73PHMRS3FTH7DP5ONQ7A5CNFSM4H4OOXJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZCFRJI#issuecomment-507795621>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZ273WWS7LVUE65LLTP5ONQ7ANCNFSM4H4OOXJA>
.
|
Guess so...looking into it. Thanks Jeff |
What happened just before the problem occurred
Some backend search constraints were implemented in #630 by me which cut out some extra database queries if your search query is less than 3 characters long.
Since then the entire UI has been updated - but if you make any query it re-renders the old UI and you can't get back to the new one:
Less priority -
Was initially going to open this issue to say constraint performance could be improved on a lot by adding frontend JS constraints - because currently a query less than 3 chars long still causes a page reload.
Relevant URLs
https://
PublicLab.org username
(to help reproduce the issue)
Browser, version, and operating system
For bug reports, fill out the above template; for feature requests, you can delete the template.
The text was updated successfully, but these errors were encountered: