Fix search bug

[cesswairimu]

Fixes #769

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/mapknitter-reviewers for help, in a comment below

[codeclimate]

Code Climate has analyzed commit b5643c12 and detected 0 issues on this pull request.

View more on Code Climate.

[cesswairimu]

[codecov]

Codecov Report

Merging #785 into main will increase coverage by 0.37%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
+ Coverage   71.08%   71.46%   +0.37%     
==========================================
  Files          35       35              
  Lines        1335     1335              
==========================================
+ Hits          949      954       +5     
+ Misses        386      381       -5

Impacted Files	Coverage Δ
app/helpers/front_ui_helper.rb	57.14% <0%> (+7.14%)	⬆️
app/controllers/maps_controller.rb	92.17% <100%> (+3.57%)	⬆️

[cesswairimu]

@publiclab/mapknitter-reviewers please review

[jywarren]

Ah it was a failure with the rubocop linter!

[jywarren]

Inspecting 28 files
.........................W..
Offenses:
app/helpers/front_ui_helper.rb:4:5: W: Lint/UselessAssignment: Useless assignment to variable - img. Use || instead of ||=.
    img ||= "/images/yarn.png"
    ^^^
28 files inspected, 1 offense detected

[jywarren]

🎉 Great!!!