Backend search constraints (length & whitespace)

[sashadev-sky]

References ##520 (comment) (<=== Add issue number here)

Note there is a PR open for this but that implementation was not working as expected originally and is also stale now so going to try to just solve the problem myself and close that one

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[codeclimate]

Code Climate has analyzed commit 2c46a2bc and detected 0 issues on this pull request.

View more on Code Climate.

[sashadev-sky]

@publiclab/reviewers

[codecov]

Codecov Report

Merging #630 into main will increase coverage by <.01%.
The diff coverage is 79.59%.

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
+ Coverage   71.27%   71.27%   +<.01%     
==========================================
  Files          32       33       +1     
  Lines        1288     1295       +7     
==========================================
+ Hits          918      923       +5     
- Misses        370      372       +2

Impacted Files	Coverage Δ
lib/not_at_origin_validator.rb	100% <100%> (ø)
app/controllers/maps_controller.rb	90.51% <69.23%> (-3.12%)	⬇️
app/models/map.rb	85.52% <80%> (+0.81%)	⬆️

[grvsachdeva]

Looks good!! I noticed that in issue and in #535 we have also talked about not allowing the search of blank spaces. I would reframe that proposal -- Do you think, we should allow the search term to be a combination of letters and numbers only?

Thanks!

[sashadev-sky]

@gauravano I was going to do this in a follow-up PR - got a little lazy here. It's not that much work so I will just implement it here and mention you for another review. Otherwise this should have been an FTO so I feel bad

[grvsachdeva]

No issues. Let me know when you're done or need help. Thank you!

[sashadev-sky]

@gauravano ok this is ready. this is a backend implementation that imposes a 3 character limit, not including spaces. So it allows the person to type spaces and submit them and it trims left and right whitespace and extra white space between words so you can search for a map named "new york" like

"  new     york    "

and itll still find it.

But it doesn't include spaces in the character count so if you tried to search "nn " it would impose the character count on you.

Also does not allow for blank search.

Any further restrictions and some optimizations should be a follow up on the front-end.

I also did a lot of refactoring of map.rb but the main driver behind this code is in the search action in maps controller

let me know if its good to go! Thanks :)

[jywarren]

Oops, i merged your header fix and now I think it created a conflict here! Sorry!

[sashadev-sky]

@jywarren rebased!

[jywarren]

Super!!!