-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update css selector test #1602
Update css selector test #1602
Conversation
|
@@ -16,10 +16,34 @@ class ComponentSpecificSelectorsTest < Minitest::Test | |||
IGNORED_SELECTORS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't taken a closer look at the .Button
and .ActionList
selectors. Should we ignore them for now? At least until we move the remaining component styles from PCSS.
I tried it locally but for some reason selectors with attributes don't seem to work. E.g. adding .ActionListItem[hidden] + .ActionList-sectionDivider
to IGNORED_SELECTORS
still made it show up as a failure? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the [
ignore and this looks good to me 👍🏻
Co-authored-by: River Lynn Bailey <river.bailey@testdouble.com>
Thanks! 🙇 Yes, that seems to ignore all the attributes in selectors. Today I might look into adding more previews for Update: PR #1606 |
Description
This is a follow-up to #1574 and adds some more previews to:
Also added some selectors to
IGNORED_SELECTORS
that are mostly old/deprecated classes that we still need to migrate on dotcom before we can remove them.Integration
No
Merge checklist
Added/updated documentation