Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css selector test #1602

Merged
merged 8 commits into from
Nov 14, 2022
Merged

Update css selector test #1602

merged 8 commits into from
Nov 14, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Nov 14, 2022

Description

This is a follow-up to #1574 and adds some more previews to:

Label Blankslate
Screen Shot 2022-11-14 at 17 29 43 Screen Shot 2022-11-14 at 17 31 21

Also added some selectors to IGNORED_SELECTORS that are mostly old/deprecated classes that we still need to migrate on dotcom before we can remove them.

Integration

Does this change require any updates to code in production?

No

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2022

⚠️ No Changeset found

Latest commit: 494d6a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@simurai simurai added the skip changeset Pull requests that don't change the library output label Nov 14, 2022
@simurai simurai temporarily deployed to github-pages November 14, 2022 08:11 Inactive
@@ -16,10 +16,34 @@ class ComponentSpecificSelectorsTest < Minitest::Test
IGNORED_SELECTORS = {
Copy link
Contributor Author

@simurai simurai Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't taken a closer look at the .Button and .ActionList selectors. Should we ignore them for now? At least until we move the remaining component styles from PCSS.

I tried it locally but for some reason selectors with attributes don't seem to work. E.g. adding .ActionListItem[hidden] + .ActionList-sectionDivider to IGNORED_SELECTORS still made it show up as a failure? 🤔

@simurai simurai marked this pull request as ready for review November 14, 2022 11:14
@simurai simurai requested review from a team, jonrohan and mxriverlynn November 14, 2022 11:14
Copy link
Contributor

@mxriverlynn mxriverlynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the [ ignore and this looks good to me 👍🏻

Co-authored-by: River Lynn Bailey <river.bailey@testdouble.com>
@jonrohan jonrohan enabled auto-merge (squash) November 14, 2022 21:21
@jonrohan jonrohan merged commit 8a6d45d into main Nov 14, 2022
@jonrohan jonrohan deleted the update-css-selector-test branch November 14, 2022 21:21
@simurai
Copy link
Contributor Author

simurai commented Nov 15, 2022

@mxriverlynn add the [ ignore and this looks good to me 👍🏻

Thanks! 🙇 Yes, that seems to ignore all the attributes in selectors.

Today I might look into adding more previews for flash and dropdown and ignore the rest (ActionList/Button).

Update: PR #1606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset Pull requests that don't change the library output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants