Update previews and get CSS coverage to pass #1606
Conversation
|
simurai
added
the
skip changeset
|
| @@ -14,16 +14,34 @@ class ComponentSpecificSelectorsTest < Minitest::Test | |||
| include Primer::RenderPreview | |||
|
|
|||
| IGNORED_SELECTORS = { | |||
| :global => [/^\d/, ":", /\[.*\]/], | |||
| Primer::Alpha::ActionList => [/^to/], | |||
There was a problem hiding this comment.
I moved /^to/ back to :global and also added /^from/. I think they are used for keyframe animations like:
@keyframes checkmarkIn {
from {
clip-path: inset(16px 0 0 0);
}
to {
clip-path: inset(0 0 0 0);
}
}and probably used for other components at some point.
| ".ActionListItem.ActionListItem--hasSubItem > .ActionListContent", | ||
| ".ActionListItem.ActionListItem--hasSubItem>.ActionListContent", |
There was a problem hiding this comment.
I had to repeat this. I assume because the whitespace around the child selector (>)?
Co-authored-by: simurai <simurai@users.noreply.github.com>
Description
This is a follow-up to #1602 and adds some more previews and ignores some selectors for:
flashdropdownTo make the "CSS coverage" pass I also added the remaining selectors to
IGNORED_SELECTORSfor:ActionListButtonWe can take a closer look once we move the styles from Primer CSS. And might be good to have
mainnot fail for too long.Integration
No
Merge checklist
Added/updated documentation