Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updating component previews for selector test coverage #1604

Closed
wants to merge 8 commits into from

Conversation

mxriverlynn
Copy link
Contributor

@mxriverlynn mxriverlynn commented Nov 14, 2022

⚠️ WIP: DO NOT REVIEW ⚠️

Description

this PR updates various component previews for lookbook, to add coverage for component specific selector tests. updated components include:

  • Primer::Alpha::ActionList
  • Primer::Beta::BlankSlate
  • Primer::Beta::Label
  • Primer::Beta::Button

also includes a few other fixes, like correcting the links used in ActionList to point to # instead of /, preventing the lookbook previews from loading the lookbook site inside of itself when clicked.

Integration

Does this change require any updates to code in production?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews

@changeset-bot
Copy link

changeset-bot bot commented Nov 14, 2022

🦋 Changeset detected

Latest commit: dccad27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mxriverlynn mxriverlynn temporarily deployed to review-pr-1604 November 14, 2022 18:13 Inactive
@mxriverlynn mxriverlynn temporarily deployed to github-pages November 14, 2022 18:17 Inactive
@mxriverlynn
Copy link
Contributor Author

closing in favor of #1602

@jonrohan jonrohan deleted the mxriverlynn/component-selector-tests branch February 13, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Pull requests that update CSS code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant