Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skin-level settings #4924

Closed
2 tasks done
peppy opened this issue Jun 5, 2019 · 5 comments
Closed
2 tasks done

Skin-level settings #4924

peppy opened this issue Jun 5, 2019 · 5 comments
Labels
area:settings area:skinning epic A feature of core importance (and also requiring considerable effort and thought). priority:2 Moderately important. Relied on by some users or impeding the usability of the game

Comments

@peppy
Copy link
Member

peppy commented Jun 5, 2019

Right now, there are quite a few pull requests coming through which implement new customisation options which don't fit at a game-wide level. They also don't fit well in ruleset-specific options, as those are generally considered player settings which you would never want overridden by a skin.

This will add databased skin settings, with user customisation via a UI. Note that this does not encompass a full skin editor (ie. sprite changing) but focuses on settings specifically – things you would find in skin.ini historically.

@peppy peppy added this to the July 2019 milestone Jun 5, 2019
@peppy peppy added area:settings area:skinning epic A feature of core importance (and also requiring considerable effort and thought). labels Jun 5, 2019
@jorolf
Copy link
Contributor

jorolf commented Jun 5, 2019

What about a way to sync these settings between skins? Having to switch them everytime you change the skin can be a bit repetitive.

@peppy
Copy link
Member Author

peppy commented Jun 5, 2019

User overrides will not be attached to specific skins. You will also eventually be able to modify skins though, should you wish to change skin-specific settings. I have all bases covered.

@peppy
Copy link
Member Author

peppy commented Oct 30, 2019

Deprioritising (editor is higher priority for now).

@peppy
Copy link
Member Author

peppy commented Feb 11, 2022

The scope of this has changed slightly. The new settings will be part of the skin editor (exposed as a property dialog and using similar automatic setting logic as what we use for mods). Hoping to get to this in the next few months.

@peppy peppy added the priority:2 Moderately important. Relied on by some users or impeding the usability of the game label Feb 11, 2022
@peppy
Copy link
Member Author

peppy commented Jun 13, 2022

This has since been implemented 🎉

@peppy peppy closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:settings area:skinning epic A feature of core importance (and also requiring considerable effort and thought). priority:2 Moderately important. Relied on by some users or impeding the usability of the game
Projects
None yet
Development

No branches or pull requests

2 participants