Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable/disable showing followpoints #15766

Closed
wants to merge 2 commits into from

Conversation

Piggey
Copy link
Contributor

@Piggey Piggey commented Nov 23, 2021

Similar to "show cursor trail" option

Showcase

I used to have a lot of the same copies of the skin only to delete followpoints, so I thought this could be a nice quality of life improvement.

Unfortunately this way doesn't allow followpoints to be toggled "on the fly" during gameplay (as cursor trail can be).

@bdach
Copy link
Collaborator

bdach commented Nov 23, 2021

Unfortunately this way doesn't allow followpoints to be toggled "on the fly" during gameplay (as cursor trail can be).

this is a rather large shortcoming, all skin settings are expected to take effect immediately.

additionally, i want to say something like that was planned in the long run, but not using the implementation presented above. it would be better to put a setting like this in a skin settings screen (something like #4924 proposes) rather than add yet another switch button to the already-sprawling settings menu.

generally we ask to open a discussion first before PRing new functionality for precisely this reason (things may already be planned in a better/more organised way, just deprioritised in favour of other things).

@peppy
Copy link
Member

peppy commented Nov 24, 2021

Follow points are a vital element of gameplay. As @bdach has said, if you want this behaviour you will need to edit the skin. We don't want 100 toggles like this for each and every visual element.

We will make this easier to from from in-game in the future.

@peppy peppy closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants