Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SkinInfo key to databased Settings table #4922

Closed
peppy opened this issue Jun 5, 2019 · 0 comments · Fixed by #4926
Closed

Add SkinInfo key to databased Settings table #4922

peppy opened this issue Jun 5, 2019 · 0 comments · Fixed by #4926
Labels
area:skinning realm deals with local realm database

Comments

@peppy
Copy link
Member

peppy commented Jun 5, 2019 •
edited
Loading

Skin settings need to be stored at the database. As a first step, they should still be re-parsed every time from the skin.ini as we have not yet got support for all settings to be migrated across. Eventually they will be read once from the ini and then the file will be discarded.
This was referenced Jun 5, 2019
Closed
Merged
@peppy peppy added realm deals with local realm database area:skinning pending review labels Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:skinning realm deals with local realm database
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add skin settings to database peppy/osu
1 participant
@peppy