Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit error graph and key overlay not shown with HUD off #12039

Open
fluffetyfluff opened this issue Mar 17, 2021 · 11 comments
Open

Hit error graph and key overlay not shown with HUD off #12039

fluffetyfluff opened this issue Mar 17, 2021 · 11 comments
Labels
area:gameplay priority:1 Very important. Feels bad without fix. Affects the majority of users. type:cosmetic

Comments

@fluffetyfluff
Copy link

osu!stable currently shows the hit error graph (and key overlay) even while the score overlay is disabled.
image

osu!lazer, on the other hand, doesn't show anything. This might be because the option is named "HUD overlay visibility mode" (interestingly enough, the notification still reads "The score overlay is currently disabled"), but I do not think disabling the entire HUD is the point of disabling the score overlay. In my opinion, disabling score is to reduce distractions while playing, but the hit error bar is an integral part of gameplay.
image

Is this an intended change?

@bdach
Copy link
Collaborator

bdach commented Mar 17, 2021

This might be eventually addressed by either: more skin/HUD customisation options or legacy layouts (#4632), or alternate methods of displaying the error bar (#3209).

I see it as a matter of personal preference. Personally I don't miss the hit error bar one iota (I like having the HUD fully off), but obviously if it is deemed that the general consensus is that it should unconditionally return for everyone, so be it.

@bdach bdach changed the title Discrepancy between hiding score overlay in osu!lazer and osu!stable Hit error graph and key overlay not shown with HUD off Mar 17, 2021
@Joehuu
Copy link
Member

Joehuu commented Mar 17, 2021

Duplicate of #11322, and that closed issue is broadly tracked in #4924. @bdach not sure if I should close this as I believe specific issues should be kept open.

@fluffetyfluff
Copy link
Author

Ah naturally I forgot to delete is:open when searching the issue tracker. Oops!
I think having a separate option to remove the hit error bar might work better (keeping Shift+Tab functionality similar to stable).

@bdach
Copy link
Collaborator

bdach commented Mar 17, 2021

I suppose we can keep this open for searchability given it's been reported multiple times now...

@peppy peppy added the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Mar 17, 2021
@peppy
Copy link
Member

peppy commented Jun 8, 2021

The path forward here is likely going to involve adding support to the skin layout editor to let the user choose when certain elements appear. I'm intending to get to this but still figuring out the UX (how things should be exposed/named to provide enough functionality while still keeping it understandable).

Once this is done, the Shift-Tab cycle options would return to a bool selection, with the extra overloaded behaviour coming from the user's layout settings.

@LeaPhant
Copy link

LeaPhant commented Dec 7, 2023

Any updates on this? #11322 / #4924 were marked as completed, key overlay got its own toggle in settings but it's still not possible to do the same for hit error graph.

@bdach
Copy link
Collaborator

bdach commented Dec 7, 2023

No updates.

key overlay got its own toggle in settings

This just hasn't been moved yet. It'll eventually be moved to skin editor.

@ana-rchy
Copy link

ana-rchy commented Feb 2, 2024

bump for wanting more attention on this

@cesarila2
Copy link

Before coming to this issue, I was hoping that the "Playfield ("osu!" only)" would stay enabled when HUD is hidden. As it stands, I'm not sure what the difference between "HUD ("osu!" only)" and "Playfield ("osu!" only)" is supposed to be.

@bdach
Copy link
Collaborator

bdach commented May 2, 2024

what the difference between "HUD ("osu!" only)" and "Playfield ("osu!" only)" is supposed to be

The playfield layer allows you to attach things to the playfield rather than to corners of the screen. It's not supposed to impact visibility in any way.

@peppy
Copy link
Member

peppy commented May 2, 2024

The playfield layer allows you to attach things to the playfield rather than to corners of the screen. It's not supposed to impact visibility in any way.

It might actually make sense for things on this layer to be visible always, given they are supposed to be attached to the playfield 🤔 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gameplay priority:1 Very important. Feels bad without fix. Affects the majority of users. type:cosmetic
Projects
None yet
Development

No branches or pull requests

7 participants