Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplementation of backported ObjectSubForm and ISubformFactory adapter #41

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

petschki
Copy link
Member

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

petschki commented Mar 22, 2022

@mauritsvanrees is it ok to create a 1.9.x branch here for Plone 5.2.x buildout.coredev this PR needs the backports in plone.z3cform which only work in Plone 6 so I would bump this version to 2.0.0.dev0

@mauritsvanrees
Copy link
Sponsor Member

Please create a 1.x then.

@petschki
Copy link
Member Author

done

@petschki
Copy link
Member Author

tested here plone/buildout.coredev#782

@petschki petschki merged commit b7b5a34 into master Mar 22, 2022
@petschki petschki deleted the backport-autoextensible-subform branch March 22, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants