Use latest z3c.form in Plone Classic UI

[petschki]

PLIP (Plone Improvement Proposal)

Responsible Persons

Proposer: @petschki

Abstract

This PLIPs mission is to upgrade z3c.form to the latest available version in Plone Classic UI.

Assumption

Right now z3c.form is pinned to the latest 3.x version because of the dependencies to the subform functionality provided by z3c.form.object.SubformAdapter and z3c.form.object.ObjectSubForm. This has been removed in z3c.form since 4.x

Proposal & Implementation

To get the latest z3c.form we have to backport subform functionality to plone.z3cform and figure out which core packages needs to be refactored.

For addons we have to provide a deprecation message to the new plone.z3cform module

Deliverables

• Compatibility with latest z3c.form #3460
• Compatibility with latest z3c.form plone.app.portlets#161
• Compatibility with latest z3c.form plone.app.z3cform#146
• Reimplementation of backported ObjectSubForm and ISubformFactory adapter plone.autoform#41
• use latest z3c.form plone.z3cform#20

Participants

• @petschki

[petschki]

@plone/framework-team

I've created a branch with the updated z3c.form version and this what happened on jenkins ... plone/buildout.coredev#782

[petschki]

plone.autoform and plone.app.portlets can safely be merged because there are only backwards compatible test fixes. CMFPlone has a backward compatible update to login form and can be merged too. The plone(.app).z3cform package Updates need z3c.form >= 4 and therefore an updated versions.cfg of buildout.coredev …

/cc @mauritsvanrees @jensens might wanna have a look?

[petschki]

PS: jenkins is down to 3 failing tests. I think I can fix them later today.

[tisto]

@petschki I personally don't think this requires a PLIP. Though, for what it is worth I am +1.

[ale-rt]

+1 with this PLIP and what with Timo says about not having a PLIP for this!
Thanks @petschki

[petschki]

Thanks for your comments. Indeed not really worth a PLIP ... I have merged the updates in plone.(app.)z3cform packages and bumped z3c.form version to 4.2 in cordev 6.0 today ... everything runs smooth.