-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix implementation for sub form adapter #116
Conversation
My first thought is: Attention we use an outdated z3c.form in Plone and the API you use just does not exist in the latest major release https://github.com/zopefoundation/z3c.form/blob/master/src/z3c/form/object.py and https://github.com/zopefoundation/z3c.form/blob/master/CHANGES.rst#330-2016-03-09 And the reason we use an outdated z3c.form is exactly this removal. |
Then we should remove it and merge #115 and close this one.
So you are saying we need to keep using a version from 5 years ago because of the removed |
Yes, its that worse. Nobody ever looked into it. It is probably time. But my personal z3c.form Zen-level was never enough for this. |
I can start a PR. Ticket is created: plone/plone.z3cform#19 |
But how do we proceed with this PR and #114? Do we remove the custom adapter here? Do we actually need it? I tried without and it still works as expected. |
I'm not sure why this this Sometimes it helps to look at the history. The adapter was added here, in 2012: Although that doesn't tell me much either. However, using an outdated z3c.form API is not a problem in my opinion. We ARE using the outdated z3c.form API. I think @thomasmassmann's fix is totally valid, if we need it at all. |
I'd recommend removing the ZCML registration with #115 and get rid of |
so in the meantime coredev build is green with the latest z3c.form plone/buildout.coredev#782 and might get merged soon for Plone 6 ... but I think the whole subform implementation has to be rewritten here. Maybe the docs have some pointers for that: https://z3cform.readthedocs.io/en/latest/mustread/subform.html |
I thought the idea was that you (or someone else) would copy the subform implementation from |
That was my first intention when investigating z3c.form update in coredev. But this |
For the sake of completeness: due to the fact, that I'll |
this got fixed in #120 |
The sub form adapter needs a different signature than originally provided.
With those changes it is possible to have an
AutoExtensibleForm
as sub form in a data grid field.This fixes #114.
There is another PR for this: #115. But I don’t think we should remove it.
@jensens, what’s your opinion on this?