-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate error message, simplify error handling #75
Conversation
@tschorr thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
Jenkins failures are actually meaningful:
-> test is assuming the incorrect error message, we need to fix the test after merging this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tschorr Thanks for working on this. I think there's one thing missing...
@jenkins-plone-org please run jobs |
RegistrationTool.pasValidation expects translated error messages, however the password policy plugin doesn't translate the minimum length error message. Also simplify the error handling.
This is a follow up to plone/plone.restapi#1630 - the idea is to use the correctly rendered error message for display in Volto's
PasswordReset.jsx
(without this fix, the actual value ofmin_chars
will not be rendered).