Fix password validation tests

[tschorr]

Fix tests failing because of plone/Products.PlonePAS#75, merge after that PR.

[mister-roboto]

@tschorr thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[tschorr]

@jenkins-plone-org please run jobs

[tschorr]

Failure in pull-request-6.1-3.11 looks unrelated.

[tschorr]

@jenkins-plone-org please run jobs

[tschorr]

This time pull-request-6.1-3.11 has passed, but it looks like the remaining Jenkins jobs are not started for some reason. Jenkins build queue is empty ...(?)

[tschorr]

@jenkins-plone-org please run jobs

[tschorr]

I'm stuck here. The pull-request-6.0-3.x Jenkins jobs never start (Jenkins build queue is empty), but they are required to run before I can merge the PR. @gforcada @davisagli any ideas?

[davisagli]

@tschorr I think I understand: this is targeting the master branch of CMFPlone, which is only used for Plone 6.1, so it is correct that it only triggers the builds for 6.1. However, the branch protection rules were not updated, so github was still expecting builds to run for 6.0. I just updated the branch protection rules so that only the Plone 6.1 job is required.

Since the change in PlonePAS is on a branch which is still used by both Ploen 6.0 and Plone 6.1, we also need this test fix in the 6.0.x branch of CMFPlone.

[davisagli]

@tschorr I submitted the backport in #3788

[tschorr]

@tschorr I think I understand: this is targeting the master branch of CMFPlone, which is only used for Plone 6.1, so it is correct that it only triggers the builds for 6.1. However, the branch protection rules were not updated, so github was still expecting builds to run for 6.0. I just updated the branch protection rules so that only the Plone 6.1 job is required.

Since the change in PlonePAS is on a branch which is still used by both Ploen 6.0 and Plone 6.1, we also need this test fix in the 6.0.x branch of CMFPlone.

@davisagli thanks for sorting this out. I think I didn't see any differences between master and 6.0x when I created this PR and I didn't know that the master branch is only used for Plone 6.1.