Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display password validation error if available; update minimum password length #4801

Merged
merged 10 commits into from
Jun 6, 2023

Conversation

tschorr
Copy link
Contributor

@tschorr tschorr commented May 23, 2023

Since now plone.restapi respects the password policy (s. plone/plone.restapi#1630), Volto should display validation errors from the PAS's PasswordPolicyPlugin or other plugins, e.g. Products.PasswordStrength. See also plone/Products.PlonePAS#75 which fixes the error message provided by the plugin.

Also update the minimum password length to the new default.

@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 4936de5
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/647f3a97966cd80008f94103

@tschorr tschorr self-assigned this May 23, 2023
@cypress
Copy link

cypress bot commented May 23, 2023

Passing run #5419 ↗︎

0 493 20 0 Flakiness 0

Details:

Merge branch 'master' into tschorr_display_validation_error
Project: Volto Commit: 4936de527f
Status: Passed Duration: 15:26 💡
Started: Jun 6, 2023 1:57 PM Ended: Jun 6, 2023 2:13 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@tschorr tschorr marked this pull request as draft May 23, 2023 07:37
@tschorr tschorr marked this pull request as ready for review May 23, 2023 13:37
@tschorr tschorr changed the title WIP: Display password validation error if available; update minimum password length Display password validation error if available; update minimum password length May 23, 2023
@wesleybl
Copy link
Member

@tschorr after the user sets the password the first time, how does he change the password? I didn't see a link where he can do this.

@tschorr
Copy link
Contributor Author

tschorr commented May 24, 2023

@tschorr after the user sets the password the first time, how does he change the password? I didn't see a link where he can do this.

@wesleybl you can change your password any time by clicking on the 'forgot password' link in the login component.

@wesleybl
Copy link
Member

@tschorr ah cool! I hadn't realized that. I would expect a link in the menu after login. Thanks!

@pbauer pbauer merged commit 58a53fb into master Jun 6, 2023
@pbauer pbauer deleted the tschorr_display_validation_error branch June 6, 2023 14:38
sneridagh added a commit that referenced this pull request Jun 6, 2023
* master:
  Use a Container from the registry in the Form component and fallback to the Semantic UI one (#4849)
  Display password validation error if available; update minimum password length (#4801)
sneridagh added a commit that referenced this pull request Jun 8, 2023
* master: (26 commits)
  Update Brazilian Portuguese translations (Fixes #4853)
  Convert header class to function (#4767)
  Use a Container from the registry in the Form component and fallback to the Semantic UI one (#4849)
  Display password validation error if available; update minimum password length (#4801)
  Do not break requires validation on number fields with value 0 (#4841)
  Search Block: Add support for advanced facets that are displayed on demand (#4784)
  Release 17.0.0-alpha.9
  Fix navigation sections in 404 pages (#4836)
  fix special characters in request urls (#4825)
  Fix block is undefined in StyleWrapper helper when building classnames (#4827)
  Fix glossary warning due to lack of empty line before a term (#4820)
  Release changelog for 16.20.7 (#4816)
  Release 17.0.0-alpha.8
  Add supported languages (#4811)
  Fix html tag lang attribute in SSR (#4803)
  Finnish translation forwardport (#4084) (#4810)
  Control panel for relations (#3382)
  Add guard in case of malformed blocks are present (at least id and title should be present) (#4802)
  fixed the issue #4660 - shouldn't use a hook like function name for a variable (#4693)
  Fix HMR of @plone/volto (#4799)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants