feat: customized input UI component to support password visibility to… #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Good work @cybertron15 😃,
Thank you for raising the PR. Soon, the owner/maintainers will review it and offer feedback/suggestions.
Meanwhile if you enjoy contributing to the project, please consider giving it a star ⭐.
|
Thank you for following the naming conventions! 🙏 |
hemantwasthere
requested changes
Oct 28, 2023
|
working on it |
|
made the requested changes @hemantwasthere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I customized the input UI component to support password visibility toggle feature in both LIGHT and DARK mode. So whenever we use input component and set type='password' we'll automatically get the input field with password visibility toggle feature.
Fixes #133
Fixes #138
Loom Video
Video
Type of change
How should this be tested?
you can test this by trying to sign in or signup and try to toggle the password visibility
Mandatory Tasks