Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added the password show and hide feature in signin and signup page #138

Conversation

Anandateertha
Copy link
Contributor

@Anandateertha Anandateertha commented Oct 12, 2023

What does this PR do?

This PR adds the show and hide feature for the password in signin and signup pages. This increases the privacy and security of the user using the application.

Fixes #127

BEFORE [ The password section does not contain any button to hide or unhide the password ]

image

AFTER [ Here I have added a button to hide and unhide the user's password ]

AFTER.mp4

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  1. Go to http://app.localhost:3000/signin or http://app.localhost:3000/signup
  2. Observe the password input section.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Thank you for following the naming conventions! 🙏

@Sarhan41
Copy link
Contributor

Bro won't this thing will make whole page client side rendered?

@github-actions
Copy link

Hey there, there is a merge conflict, can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 merge conflict Merge Conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password Visiblity Feature For Better Ux
2 participants