Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom Password Input with Show and Hide Feature for Sign-In and Sign-Up Pages #133

Closed
wants to merge 1 commit into from

Conversation

Kiranism
Copy link

@Kiranism Kiranism commented Oct 11, 2023

What does this PR do?

This pr adds the feature for password visibility.

Created a password input component for the toggle eye functionality and used in signin signup page.
Fixes #127

Loom Video: https://www.loom.com/share/35d64d031d04463eaf37e89a000a5e76

Type of change

  • [✅] New feature (non-breaking change which adds functionality)

How should this be tested?

Navigate to the signup / signin page and observe the password input field.

Mandatory Tasks

  • [✅] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Thank you for following the naming conventions! 🙏

@Kiranism Kiranism changed the title password-input for visibility for signin and signup page feat: Custom Password Input with Show and Hide Feature for Sign-In and Sign-Up Pages #138 Oct 12, 2023
@Kiranism Kiranism changed the title feat: Custom Password Input with Show and Hide Feature for Sign-In and Sign-Up Pages #138 feat: Custom Password Input with Show and Hide Feature for Sign-In and Sign-Up Pages Oct 12, 2023
@github-actions
Copy link

Hey there, there is a merge conflict, can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 merge conflict Merge Conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password Visiblity Feature For Better Ux
1 participant