Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: use require.Eventually #300

Closed
wants to merge 1 commit into from
Closed

proxy: use require.Eventually #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/proxy/backend/backend_conn_mgr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,9 @@ func TestGracefulCloseWhenActive(t *testing.T) {
proxy: func(_, _ *pnet.PacketIO) error {
ts.mp.GracefulClose()
time.Sleep(300 * time.Millisecond)
require.Equal(t, statusNotifyClose, ts.mp.closeStatus.Load())
require.Eventually(t, func() bool {
return statusNotifyClose == ts.mp.closeStatus.Load()
}, time.Second, 100*time.Millisecond)
Comment on lines +676 to +678
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check #204

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then can we just close the issue?

return nil
},
},
Expand Down