proxy: use require.Eventually #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
reviewed
Jun 2, 2023
Comment on lines
+676
to
+678
| require.Eventually(t, func() bool { | ||
| return statusNotifyClose == ts.mp.closeStatus.Load() | ||
| }, time.Second, 100*time.Millisecond) |
There was a problem hiding this comment.
Then can we just close the issue?
djshow832
reviewed
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #192
Problem Summary: There are no other
time.Sleeptests can benefit fromrequire.Eventually.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.