Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: revert PR 201 because to make the test accurate #204

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close None

Problem Summary:
#201 tried to make the test faster but there's a misunderstanding here:
I want to prove that the status of closeStatus is always statusNotifyClose and will never change to statusClosing or statusClosed, so I waited for 300ms.
If it's changed to require.Eventually, it will definitely return on the first try.

What is changed and how it works:
Revert the code.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox January 31, 2023 07:37
@xhebox xhebox merged commit f388efb into pingcap:main Jan 31, 2023
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 7, 2023
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
@djshow832 djshow832 mentioned this pull request Jun 2, 2023
8 tasks
@djshow832 djshow832 deleted the revert_201 branch September 2, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants