Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): Optimize the performance when getting the metadata of Kafka topics (#9060) #9104

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9060

What problem does this PR solve?

Issue Number: close #8959 close #8957

What is changed and how it works?

Get the metadata by needs instead of getting all topic's metadata.

Fixed a bug in the original implementation, the semantics of the original GetTopicMeta v2 implementation and v1 were not the same. Now it's the same, add a continue and it's fine.

Check List

Tests

  • Unit test
  • Manual test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

Optimize the performance when TiCDC gets the metadata of Kafka topics

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 31, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 31, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 31, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 force-pushed the cherry-pick-9060-to-release-6.5 branch from 5e50a31 to 5c1b3b8 Compare June 1, 2023 08:45
@ti-chi-bot ti-chi-bot bot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 1, 2023
@Rustin170506
Copy link
Member

/run-all-tests

/test all

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 1, 2023
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

Rustin170506 commented Jun 1, 2023

  • Close topic manager

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Copy link
Member

/run-all-tests

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Copy link
Member

Tested locally:
exist:

[2023/06/02 16:02:11.879 +08:00] [INFO] [kafka.go:412] ["topic already exists"] [topic=ticdc-test1]
[2023/06/02 16:02:11.891 +08:00] [INFO] [kafka.go:598] ["Kafka config item found"] [topicName=ticdc-test1] [configName=min.insync.replicas] [configValue=1]
[2023/06/02 16:02:11.894 +08:00] [INFO] [kafka.go:598] ["Kafka config item found"] [topicName=ticdc-test1] [configName=max.message.bytes] [configValue=3145728]
[2023/06/02 16:02:13.035 +08:00] [INFO] [kafka_manager.go:142] ["store topic partition number"] [namespace=] [changefeed=] [topic=ticdc-test1] [partitionNumber=3]

not exist:

[2023/06/02 16:04:27.110 +08:00] [INFO] [kafka_manager.go:269] ["Kafka admin client create the topic success"] [namespace=] [changefeed=] [topic=ticdc-test2] [partitionNumber=3] [replicationFactor=1] [duration=95.302833ms]

@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 2, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 1854e38

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2023
@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

/retest

@Rustin170506
Copy link
Member

/run-integration-test

@Rustin170506
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 8a3bb9c into pingcap:release-6.5 Jun 2, 2023
@Rustin170506 Rustin170506 added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 7, 2023
@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request created to branch release-6.1: #9145.

ti-chi-bot added a commit to ti-chi-bot/tiflow that referenced this pull request Jun 7, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants