Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): Optimize the performance when getting the metadata of Kafka topics #9060

Merged
merged 11 commits into from
May 31, 2023
Merged

sink(ticdc): Optimize the performance when getting the metadata of Kafka topics #9060

merged 11 commits into from
May 31, 2023
+116 −415

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented May 25, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8959 close #8957

What is changed and how it works?

Get the metadata by needs instead of getting all topic's metadata.

Fixed a bug in the original implementation, the semantics of the original GetTopicMeta v2 implementation and v1 were not the same. Now it's the same, add a continue and it's fine.

Check List

Tests

  • Unit test
  • Manual test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

Optimize the performance when TiCDC gets the metadata of Kafka topics

@Rustin170506
sink(ticdc): Optimize the performance when getting the metadata of Ka…
e35acb4 
…fka topics

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 25, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels May 25, 2023
@Rustin170506
Remove useless code
d05965b 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Add rate limiter
0de3ea1 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Fix
b4a36d4 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels May 26, 2023
@Rustin170506
Fix
49faafd 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Fix test
545de53 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Remove rate limiter
03a4cd0 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506
Fix
01d7d16 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@pingcap pingcap deleted a comment from ti-chi-bot bot May 29, 2023
@Rustin170506
Add comment
29bd567 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 29, 2023
@Rustin170506
Copy link
Member Author

/test all

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 29, 2023
@Rustin170506
Copy link
Member Author

/test all

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2023
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 29bd567

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506
Copy link
Member Author

/retest

1 similar comment
@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit aefbf33 into pingcap:master May 31, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 31, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9104.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 31, 2023
@Rustin170506 @ti-chi-bot
This is an automated cherry-pick of pingcap#9060
5e50a31 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 31, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9105.

ti-chi-bot bot pushed a commit that referenced this pull request Jun 2, 2023
@ti-chi-bot
sink(ticdc): Optimize the performance when getting the metadata of Ka…
8a3bb9c 
…fka topics (#9060) (#9104)

close #8957, close #8959
@nongfushanquan nongfushanquan mentioned this pull request Jun 5, 2023
Closed
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 7, 2023
Closed
@Rustin170506 Rustin170506 mentioned this pull request Jun 7, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jun 8, 2023
@ti-chi-bot
sink(ticdc): Optimize the performance when getting the metadata of Ka…
8c3a94b 
…fka topics (#9060) (#9105)

close #8957, close #8959
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy approved these changes

@asddongmen asddongmen asddongmen approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
4 participants
@Rustin170506 @ti-chi-bot @sdojjy @asddongmen