owner(ticdc): update changefeed configuration changefeed-error-stuck-duration correctly

[wk989898]

What problem does this PR solve?

Issue Number: close #10998

What is changed and how it works?

When changefeed state has changed, reacquiring changefeed-error-stuck-duration. feedStateManager checks for new value about changefeedErrorStuckDuration every feedStateManager.Tick call so that it can sense the updated value.

Check List

Tests

• Unit test
• Manual test (add detailed scripts or steps below)
  1. start a CDC server
  2. run script

  bin/cdc cli changefeed create -c test --sink-uri "kafka://127.0.0.1:9092/test?topic=test&protocol=open-protocol&max-message-bytes=41943040&compressionType=ZLIB" --changefeed-id="test"
  bin/cdc cli changefeed pause --changefeed-id="test"
  bin/cdc cli changefeed update --changefeed-id="test" --config=changefeed.toml
  bin/cdc cli changefeed resume --changefeed-id="test"

  changefeed.toml

   changefeed-error-stuck-duration = "1h30m"

  3. check CDC log
  

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

[ti-chi-bot]

Hi @wk989898. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CharlesCheung96]

/test all

[CharlesCheung96]

Use util.GetOrZero to avoid possible nil pointer dereference

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.3879%. Comparing base (894b36f) to head (ce895c0).
Report is 10 commits behind head on master.

Additional details and impacted files

Components	Coverage Δ
cdc	61.6153% <100.0000%> (-0.0494%)	⬇️
dm	51.2472% <ø> (+0.0095%)	⬆️
engine	63.4585% <ø> (+0.0706%)	⬆️

Flag	Coverage Δ
unit	57.3879% <100.0000%> (-0.0088%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11042        +/-   ##
================================================
- Coverage   57.3966%   57.3879%   -0.0088%     
================================================
  Files           851        851                
  Lines        125469     125617       +148     
================================================
+ Hits          72015      72089        +74     
- Misses        48034      48115        +81     
+ Partials       5420       5413         -7     

[asddongmen]

/ok-to-test

[asddongmen]

Please also add an unit test case to cover this change.

[wk989898]

/test all

[wk989898]

/retest

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-12 23:47:32.668209341 +0000 UTC m=+1437806.425344910: ☑️ agreed by asddongmen.
• 2024-05-13 08:52:38.678043967 +0000 UTC m=+1470512.435179540: ☑️ agreed by CharlesCheung96.

[asddongmen]

/retest

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #11083.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #11085.