Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner(ticdc): update changefeed configuration changefeed-error-stuck-duration correctly #11042

Merged
merged 7 commits into from
May 13, 2024
Merged

owner(ticdc): update changefeed configuration changefeed-error-stuck-duration correctly #11042

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
74d8629
fix: update changefeedErrorStuckDuration
wk989898 May 7, 2024
d76f1d7
fmt
wk989898 May 7, 2024
ee34071
update
wk989898 May 9, 2024
9bfe767
update and add an unit test case
wk989898 May 9, 2024
729e395
update unit test case
wk989898 May 10, 2024
4f2667f
fix
wk989898 May 10, 2024
ce895c0
chore
wk989898 May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cdc/owner/feed_state_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"github.com/pingcap/tiflow/cdc/model"
cerrors "github.com/pingcap/tiflow/pkg/errors"
"github.com/pingcap/tiflow/pkg/upstream"
"github.com/pingcap/tiflow/pkg/util"
"github.com/tikv/client-go/v2/oracle"
pd "github.com/tikv/pd/client"
"go.uber.org/zap"
Expand Down Expand Up @@ -168,6 +169,15 @@ func (m *feedStateManager) Tick(resolvedTs model.Ts,
// `handleAdminJob` returns true means that some admin jobs are pending
// skip to the next tick until all the admin jobs is handled
adminJobPending = true
changefeedErrorStuckDuration := util.GetOrZero(m.state.GetChangefeedInfo().Config.ChangefeedErrorStuckDuration)
if m.changefeedErrorStuckDuration != changefeedErrorStuckDuration {
log.Info("changefeedErrorStuckDuration update",
zap.Duration("oldChangefeedErrorStuckDuration", m.changefeedErrorStuckDuration),
zap.Duration("newChangefeedErrorStuckDuration", changefeedErrorStuckDuration),
)
}
m.errBackoff.MaxElapsedTime = changefeedErrorStuckDuration
asddongmen marked this conversation as resolved.
Show resolved Hide resolved
m.changefeedErrorStuckDuration = changefeedErrorStuckDuration
return
}

Expand Down
Loading