-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
owner(ticdc): update changefeed configuration changefeed-error-stuck-duration correctly (#11042) #11083
owner(ticdc): update changefeed configuration changefeed-error-stuck-duration correctly (#11042) #11083
Conversation
/retest |
Manual test pass |
/retest |
1 similar comment
/retest |
@wk989898: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96, wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #11042
What problem does this PR solve?
Issue Number: close #10998
What is changed and how it works?
When changefeed state has changed, reacquiring
changefeed-error-stuck-duration
.feedStateManager
checks for new value aboutchangefeedErrorStuckDuration
everyfeedStateManager.Tick
call so that it can sense the updated value.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note