Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push down Abs to tiflash #2043

Merged
merged 13 commits into from
Jun 3, 2021
Merged

push down Abs to tiflash #2043

merged 13 commits into from
Jun 3, 2021

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Jun 1, 2021

What problem does this PR solve?

Issue Number: close #1937

Problem Summary: to keep the same behavior with mysql/tidb, abs(int64_min) should return out of range error.

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Integration test

Side effects

Release note

  • push down abs() to tiflash

@fzhedu fzhedu requested review from windtalker and leiysky June 1, 2021 10:14
@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 1, 2021

related pingcap/tidb#25018

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2021
Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 2, 2021
@leiysky
Copy link
Contributor

leiysky commented Jun 2, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@fzhedu merge failed.

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 1961
  • 2026
  • 2045

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2026
  • 2045

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2046
  • 2038
  • 2058
  • 2026

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/run-all-tests

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@fzhedu merge failed.

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2007
  • 2059
  • 2039
  • 2041
  • 2007

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/run-all-tests

2 similar comments
@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/run-all-tests

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/run-all-tests

@fzhedu fzhedu merged commit 6b0d860 into pingcap:master Jun 3, 2021
@fzhedu fzhedu added the needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 label Jun 3, 2021
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #2075

ti-srebot added a commit that referenced this pull request Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support abs function push down
5 participants