Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push down Abs to tiflash (#2043) #2075

Merged
merged 4 commits into from
Jun 18, 2021
Merged

push down Abs to tiflash (#2043) #2075

merged 4 commits into from
Jun 18, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 3, 2021 •
edited
Loading

cherry-pick #2043 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2075

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2075:release-5.0-6b0d860c1cbf

What problem does this PR solve?

Issue Number: close #1937

Problem Summary: to keep the same behavior with mysql/tidb, abs(int64_min) should return out of range error.

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Integration test

Side effects

Release note

  • push down abs() to tiflash

@fzhedu @ti-srebot
cherry pick #2043 to release-5.0
197d960 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 3, 2021
Merged
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT2 Indicates that a PR has LGTM 2. labels Jun 3, 2021
@ti-srebot ti-srebot added this to the v5.0.3 milestone Jun 3, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Jun 18, 2021

/run-all-tests

fzhedu
fzhedu approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-srebot
Copy link
Collaborator Author

@fzhedu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack).

windtalker
windtalker approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jun 18, 2021
@fzhedu
Copy link
Contributor

fzhedu commented Jun 18, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@fzhedu
Copy link
Contributor

fzhedu commented Jun 18, 2021

/run-all-tests

@ti-srebot ti-srebot merged commit e6a5566 into pingcap:release-5.0 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@fzhedu fzhedu fzhedu approved these changes

Assignees

@fzhedu fzhedu

Labels
CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
v5.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @fzhedu @windtalker