Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: push down left/right/abs to tiflash #25018

Merged
merged 30 commits into from
Jun 4, 2021

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Jun 1, 2021

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1943, pingcap/tiflash#1937

Problem Summary: push down left()/right()/abs() for tiflash

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test (done on tiflash)
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • push down left/right/abs to tiflash

@fzhedu fzhedu requested a review from a team as a code owner June 1, 2021 04:40
@fzhedu fzhedu requested review from XuHuaiyu and removed request for a team June 1, 2021 04:40
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 1, 2021
@fzhedu fzhedu requested a review from hanfei1991 June 1, 2021 04:41
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hanfei1991
  • ichn-hu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 11b3ceb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/merge

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/merge

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 3, 2021

/merge

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 4, 2021

/run-tics-test

@fzhedu
Copy link
Contributor Author

fzhedu commented Jun 4, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 99b1fa5 into pingcap:master Jun 4, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 4, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression needs-cherry-pick-release-5.0 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support left/right function push down
5 participants