Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: push down left/right/abs to tiflash #25018

Merged
merged 30 commits into from
Jun 4, 2021
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
62cd8a0
push down left/right/abs for tiflash
fzhedu Jun 1, 2021
7184601
Merge branch 'master' into left/right/abs
fzhedu Jun 1, 2021
4d2e3d5
Merge branch 'master' into left/right/abs
fzhedu Jun 3, 2021
11b3ceb
Merge branch 'master' into left/right/abs
fzhedu Jun 3, 2021
df5c5f0
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
46f271a
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
a8134dc
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
78423ce
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
c8438c7
Merge branch 'master' into left/right/abs
fzhedu Jun 3, 2021
4a28dc2
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
eb1337b
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
7669f81
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
ab9480c
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
f7c3cfe
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
d085fbb
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
f8bc559
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
4e37ab7
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
5fad98d
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
86a3c9d
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
ea0ab07
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
248acf7
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
e9a38da
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
3829fdf
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
a8b65b4
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
9b8aa9e
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
891e03f
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
0f3c2f0
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
7ea2ccd
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 3, 2021
60b8e02
Merge branch 'master' into left/right/abs
ti-chi-bot Jun 4, 2021
e2c9ce9
Merge branch 'master' into left/right/abs
fzhedu Jun 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions expression/expression.go
Original file line number Diff line number Diff line change
Expand Up @@ -999,16 +999,19 @@ func scalarExprSupportedByFlash(function *ScalarFunction) bool {
case
ast.LogicOr, ast.LogicAnd, ast.UnaryNot, ast.BitNeg, ast.Xor, ast.And, ast.Or,
ast.GE, ast.LE, ast.EQ, ast.NE, ast.LT, ast.GT, ast.In, ast.IsNull, ast.Like,
ast.Plus, ast.Minus, ast.Div, ast.Mul, /*ast.Mod,*/
ast.Plus, ast.Minus, ast.Div, ast.Mul, ast.Abs, /*ast.Mod,*/
ast.If, ast.Ifnull, ast.Case,
ast.Concat, ast.ConcatWS,
ast.Year, ast.Month, ast.Day,
ast.DateDiff, ast.TimestampDiff, ast.DateFormat, ast.FromUnixTime,
ast.JSONLength:
return true
case ast.Substr, ast.Substring:
case ast.Substr, ast.Substring, ast.Left, ast.Right, ast.CharLength:
switch function.Function.PbCode() {
case
tipb.ScalarFuncSig_LeftUTF8,
tipb.ScalarFuncSig_RightUTF8,
tipb.ScalarFuncSig_CharLengthUTF8,
tipb.ScalarFuncSig_Substring2ArgsUTF8,
tipb.ScalarFuncSig_Substring3ArgsUTF8:
return true
Expand Down