Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partition: Revert support batch_point_get for partition table in dynamic mode #45891

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Aug 8, 2023

What problem does this PR solve?

Issue Number: close #45889

Problem Summary: Revert #45748 and #45646. Batch_point_get for partition table in dynamic mode has many potential problems (see it in #45532), let's ban it now.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 8, 2023
@tiprow
Copy link

tiprow bot commented Aug 8, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #45891 (676cbef) into master (b07d10d) will increase coverage by 0.0588%.
Report is 5 commits behind head on master.
The diff coverage is 80.7692%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45891        +/-   ##
================================================
+ Coverage   73.3424%   73.4012%   +0.0588%     
================================================
  Files          1277       1280         +3     
  Lines        393378     394120       +742     
================================================
+ Hits         288513     289289       +776     
+ Misses        86485      86421        -64     
- Partials      18380      18410        +30     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3931% <80.7692%> (+0.0506%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0467% <ø> (+0.0108%) ⬆️
br 52.0291% <ø> (+0.0602%) ⬆️

@Defined2014 Defined2014 changed the title partition: revert support batch_point_get for partition table in dynamic mode partition: Revert support batch_point_get for partition table in dynamic mode Aug 8, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 8, 2023
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-08 05:54:16.236140534 +0000 UTC m=+5620.785156507: ☑️ agreed by lcwangchao.
  • 2023-08-08 06:36:20.363735467 +0000 UTC m=+8144.912751450: ☑️ agreed by bb7133.

@hawkingrei
Copy link
Member

/retest

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 0ac1bd7 into pingcap:master Aug 8, 2023
6 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #45902.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.3 ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The statement: select ... where _tidb_rowid in (...) returns an wrong result
5 participants