Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, executor: fix batch_point_get with specific table partitions #45748

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Aug 2, 2023

What problem does this PR solve?

Issue Number: close #45720

Problem Summary: I didn't check specific table partitions in batch_point_get before, support it and add tests to cover it.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2023
@tiprow
Copy link

tiprow bot commented Aug 2, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/test build

@tiprow
Copy link

tiprow bot commented Aug 2, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/test check-dev2

@tiprow
Copy link

tiprow bot commented Aug 2, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #45748 (6606e24) into master (cf7ae4c) will increase coverage by 0.1667%.
Report is 17 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45748        +/-   ##
================================================
+ Coverage   73.2076%   73.3744%   +0.1667%     
================================================
  Files          1266       1274         +8     
  Lines        390690     393693      +3003     
================================================
+ Hits         286015     288870      +2855     
- Misses        86321      86429       +108     
- Partials      18354      18394        +40     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3662% <100.0000%> (+0.1585%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0359% <ø> (-0.0109%) ⬇️
br 52.0338% <ø> (+0.0264%) ⬆️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 2, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 2, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-02 09:42:40.352730296 +0000 UTC m=+264844.295078946: ☑️ agreed by tiancaiamao.
  • 2023-08-02 10:21:01.061017533 +0000 UTC m=+267145.003366063: ☑️ agreed by mjonss.

@Defined2014
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@Defined2014
Copy link
Contributor Author

Defined2014 commented Aug 2, 2023

/hold

waiting for planner group review

@mjonss
Copy link
Contributor

mjonss commented Aug 2, 2023

/retest

@tiprow
Copy link

tiprow bot commented Aug 2, 2023

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, mjonss, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,mjonss,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member

/retest

@Defined2014
Copy link
Contributor Author

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 3, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit ef37474 into pingcap:master Aug 3, 2023
6 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #45780.

Defined2014 added a commit to Defined2014/tidb that referenced this pull request Aug 8, 2023
Defined2014 added a commit to Defined2014/tidb that referenced this pull request Aug 8, 2023
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 8, 2023
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.3 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

join partition return wrong result
6 participants