Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, execute: Support BatchPointGet for Range and List Partition #45646

Merged
merged 6 commits into from
Jul 31, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #45532

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 28, 2023
@tiprow
Copy link

tiprow bot commented Jul 28, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #45646 (a4c075d) into master (7a65395) will decrease coverage by 0.0178%.
Report is 27 commits behind head on master.
The diff coverage is 76.9230%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45646        +/-   ##
================================================
- Coverage   73.2266%   73.2088%   -0.0179%     
================================================
  Files          1270       1276         +6     
  Lines        390037     390961       +924     
================================================
+ Hits         285611     286218       +607     
- Misses        86129      86386       +257     
- Partials      18297      18357        +60     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.2002% <76.9230%> (-0.0264%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0417% <ø> (-0.0109%) ⬇️
br 52.0116% <ø> (-0.1396%) ⬇️

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jul 28, 2023
@Defined2014 Defined2014 requested a review from winoros July 31, 2023 05:26
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 31, 2023
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some minor questions

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-31 07:27:14.400347361 +0000 UTC m=+83918.342695892: ☑️ agreed by tiancaiamao.
  • 2023-07-31 11:06:35.795186 +0000 UTC m=+97079.737534551: ☑️ agreed by mjonss.

@ti-chi-bot ti-chi-bot bot merged commit fd50df6 into pingcap:master Jul 31, 2023
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support BatchPointGet for Range and List Partition
4 participants