Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass gofmt #32

Merged
merged 1 commit into from
Sep 7, 2015
Merged

Pass gofmt #32

merged 1 commit into from
Sep 7, 2015

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Sep 7, 2015

pass gofmt

pass gofmt
@xiang90
Copy link

xiang90 commented Sep 7, 2015

this is gofmt -s, right?

@zimulala
Copy link
Contributor Author

zimulala commented Sep 7, 2015

yep.

@xiang90
Copy link

xiang90 commented Sep 7, 2015

@zimulala Ideally, you should mention this in CONTRIBUTION.md and add this test into travis.

@zimulala
Copy link
Contributor Author

zimulala commented Sep 7, 2015

It's my next pr.

@ngaut
Copy link
Member

ngaut commented Sep 7, 2015

LGTM

@xiang90
Copy link

xiang90 commented Sep 7, 2015

@zimulala ah. great!

@zimulala
Copy link
Contributor Author

zimulala commented Sep 7, 2015

@xiang90 ^_^

@shenli
Copy link
Member

shenli commented Sep 7, 2015

LGTM

ngaut added a commit that referenced this pull request Sep 7, 2015
@ngaut ngaut merged commit 2396b31 into master Sep 7, 2015
@ngaut ngaut deleted the zimuxia/gofmt branch September 7, 2015 04:58
spongedu pushed a commit to spongedu/tidb that referenced this pull request Oct 26, 2019
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021
xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021
ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021
zhouqiang-cl pushed a commit that referenced this pull request Feb 17, 2022
#32391)

* expression: fix date format identifies '\n' as invalid separator (#32358)
ywqzzy pushed a commit to ywqzzy/tidb that referenced this pull request Jul 27, 2023
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
…8944) (pingcap#48990) (pingcap#32)

close pingcap#32110

Co-authored-by: crazycs <crazycs520@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants