Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix date format identifies '\n' as invalid separator (#32… #32391

Merged
merged 2 commits into from
Feb 17, 2022
Merged

expression: fix date format identifies '\n' as invalid separator (#32… #32391

merged 2 commits into from
Feb 17, 2022

Conversation

mengxin9014
Copy link
Contributor

@mengxin9014 mengxin9014 commented Feb 16, 2022 •
edited
Loading

What problem does this PR solve?

fix date formate identifies '\n' is invalid separator

Issue Number: close #32232

Problem Summary:

What is changed and how it works?

builtin_time.go

Check List

Tests

  • Unit test

Release note

fix date format identifies '\n' as invalid separator

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ngaut
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Feb 16, 2022
@ti-chi-bot
Copy link
Member

@mengxin9014: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 16, 2022
windtalker
windtalker previously approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 16, 2022
@mengxin9014
Copy link
Contributor Author

/run-all-tests

1 similar comment
@mengxin9014
Copy link
Contributor Author

/run-all-tests

ngaut
ngaut previously approved these changes Feb 16, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 16, 2022
@mengxin9014
Copy link
Contributor Author

/run-all-tests

2 similar comments
@mengxin9014
Copy link
Contributor Author

/run-all-tests

@mengxin9014
Copy link
Contributor Author

/run-all-tests

@mengxin9014 mengxin9014 dismissed stale reviews from ngaut and windtalker via 6d3e3bb February 16, 2022 10:35
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2022
LittleFall
LittleFall approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

windtalker
windtalker approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl zhouqiang-cl merged commit b854b4f into pingcap:release-5.1-20211012 Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@LittleFall LittleFall LittleFall approved these changes

@ngaut ngaut ngaut left review comments

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mengxin9014 @ti-chi-bot @ngaut @windtalker @LittleFall @zhouqiang-cl