Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Set default drainClientWait as 15s (#42134) (#48944) #48990

Conversation

crazycs520
Copy link
Contributor

This is an automated cherry-pick of #42134

What problem does this PR solve?

Issue Number: close #32110

Problem Summary:

What is changed and how it works?

ref #32111

Set default drainClientWait as 15s

The default keeps waiting maybe too rigorous, It is easy having little slow txns which we may not want to wait for them, also the idle connections may block the shutdown two.
generally, 15s is enough for an ongoing txn to finish, better provider a dynamic way to set this value.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 29, 2023
@crazycs520 crazycs520 merged commit 1cb21a5 into pingcap:tidb-6.5-with-kv-timeout-feature Nov 29, 2023
1 check passed
Copy link

ti-chi-bot bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from crazycs520. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2023
Copy link

tiprow bot commented Nov 29, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
…8944) (pingcap#48990) (pingcap#32)

close pingcap#32110

Co-authored-by: crazycs <crazycs520@gmail.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants