statistics, executor: refactor statistics on columns #21817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time-and-fate
requested review from
qw4990 and
hanfei1991
and removed request for
a team
|
/uncc hanfei1991 |
|
/cc winoros |
time-and-fate
commented
Dec 15, 2020
| @@ -275,7 +275,7 @@ func (s *testStatisticsSuite) TestBuild(c *C) { | |||
| count = col.BetweenRowCount(types.NewIntDatum(3000), types.NewIntDatum(3500)) | |||
| c.Check(int(count), Equals, 4994) | |||
| count = col.lessRowCount(types.NewIntDatum(1)) | |||
| c.Check(int(count), Equals, 9) | |||
| c.Check(int(count), Equals, 5) | |||
There was a problem hiding this comment.
This result changed because a small bug about float precision is fixed in statistics/builder.go L149
qw4990
reviewed
Dec 16, 2020
qw4990
reviewed
Dec 16, 2020
qw4990
reviewed
Dec 17, 2020
qw4990
reviewed
Dec 17, 2020
qw4990
reviewed
Dec 21, 2020
qw4990
reviewed
Dec 21, 2020
qw4990
reviewed
Dec 23, 2020
qw4990
reviewed
Dec 23, 2020
|
/run-all-tests |
|
/merge |
ti-srebot
approved these changes
Dec 24, 2020
ti-srebot
added
status/LGT2
|
/run-all-tests |
10 tasks
time-and-fate
added a commit
to time-and-fate/tidb
that referenced
this pull request
Dec 24, 2020
ti-srebot
pushed a commit
that referenced
this pull request
Dec 24, 2020
Tjianke
pushed a commit
to Tjianke/tidb
that referenced
this pull request
Dec 25, 2020
This was referenced Dec 29, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #21537
What is changed and how it works?
Please see #21537 for details.
Check List
Tests
Release note