-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: add docs for version 2 #5164
Conversation
statistics.md
Outdated
@@ -290,6 +313,31 @@ SHOW STATS_BUCKETS [ShowLikeOrWhere]; | |||
| repeats | 最大值出现的次数 | | |||
| lower_bound | 最小值 | | |||
| upper_bound | 最大值 | | |||
| ndv | 不同值的个数,当 analyze version 为 1 时,该值没有实际意义,因此会有 count 不为 0,但 ndv 为 0 的情况 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
直接说 version 为 1 时恒为 0 没有意义是不是会清晰一些?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
statistics.md
Outdated
| 列的Count-Min Sketch | √ | × | | ||
| 索引的Count-Min Sketch | √ | × | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里似乎中英文之间要空格
@time-and-fate, @qw4990, PTAL. |
@winoros, please update your pull request. |
@time-and-fate, @qw4990, PTAL. |
@winoros, please update your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please address existed comments @winoros
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@time-and-fate, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack). |
Signed-off-by: Ran <huangran@pingcap.com>
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #5217 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Yiding Cui <winoros@gmail.com>
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add descption about the analyze's changes based on the variable
tidb_analyze_version
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?