Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version 2 info in statistics #4546

Merged
merged 3 commits into from
Dec 30, 2020
Merged

Add version 2 info in statistics #4546

merged 3 commits into from
Dec 30, 2020

Conversation

ran-huang
Copy link
Contributor

Signed-off-by: Ran huangran@pingcap.com

What is changed, added or deleted? (Required)

Add descption about the analyze's changes based on the variable tidb_analyze_version

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang
Add version 2 info in statistics
9adcc45 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/medium Changes of a medium size. needs-cherry-pick-5.0 labels Dec 30, 2020
TomShawn
TomShawn approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
statistics.md Outdated Show resolved Hide resolved
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2020
winoros
winoros reviewed Dec 30, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Contributor

@winoros, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@ran-huang @TomShawn
Apply suggestions from code review
2a775ff 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang ran-huang merged commit 50ee375 into pingcap:master Dec 30, 2020
@ran-huang ran-huang deleted the statistics-v2 branch December 30, 2020 12:33
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Dec 30, 2020
@ran-huang @ti-srebot
cherry pick pingcap#4546 to release-5.0
bce4b04 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 30, 2020
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #4548

ran-huang added a commit that referenced this pull request Dec 30, 2020
@ti-srebot @ran-huang
cherry pick #4546 to release-5.0 (#4548)
6a42e12 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
@TomShawn TomShawn added the v5.0 This PR/issue applies to TiDB v5.0. label Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.0 This PR/issue applies to TiDB v5.0.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ran-huang @ti-srebot @winoros @TomShawn