Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics, executor: refactor statistics on columns (#21817) #22007

Merged

Conversation

time-and-fate
Copy link
Member

cherry-pick #21817 to release-5.0-rc


What problem does this PR solve?

Issue Number: close #21537

What is changed and how it works?

Please see #21537 for details.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • no release note.

@time-and-fate time-and-fate requested review from a team as code owners December 24, 2020 07:34
@time-and-fate time-and-fate requested review from SunRunAway and removed request for a team December 24, 2020 07:34
@time-and-fate
Copy link
Member Author

/cc qw4990,winoros

@time-and-fate
Copy link
Member Author

/uncc SunRunAway

@ti-srebot ti-srebot removed the request for review from SunRunAway December 24, 2020 07:35
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 24, 2020
@winoros
Copy link
Member

winoros commented Dec 24, 2020

/merge

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Dec 24, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 9a4f5e7 into pingcap:release-5.0-rc Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants