Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix tests which may fail because of concurrency #16446

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Apr 15, 2020

What problem does this PR solve?

Problem Summary:
image
image

What is changed and how it works?

Try to drop the table before creating it.

Related changes

Check List

Tests

  • No code

Side effects

Release note

@wjhuang2016 wjhuang2016 requested a review from a team as a code owner April 15, 2020 16:49
@ghost ghost requested review from SunRunAway and removed request for a team April 15, 2020 16:49
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjhuang2016 wjhuang2016 added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #16446 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16446   +/-   ##
===========================================
  Coverage   80.5794%   80.5794%           
===========================================
  Files           506        506           
  Lines        137540     137540           
===========================================
  Hits         110829     110829           
  Misses        18139      18139           
  Partials       8572       8572           

@sre-bot
Copy link
Contributor

sre-bot commented Apr 16, 2020

@wjhuang2016 merge failed.

@wjhuang2016
Copy link
Member Author

/run-unit-test

@wjhuang2016
Copy link
Member Author

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented Apr 26, 2020

cherry pick to release-4.0 in PR #16828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants