Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix tests which may fail because of concurrency (#16446) #16828

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 26, 2020

cherry-pick #16446 to release-4.0


What problem does this PR solve?

Problem Summary:
image
image

What is changed and how it works?

Try to drop the table before creating it.

Related changes

Check List

Tests

  • No code

Side effects

Release note

@sre-bot sre-bot requested a review from a team as a code owner April 26, 2020 05:22
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 26, 2020

/run-all-tests

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTm

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 26, 2020

Your auto merge job has been accepted, waiting for:

  • 16813

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 26, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 26, 2020

@sre-bot merge failed.

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 27, 2020

/run-all-tests

@sre-bot sre-bot merged commit 16439af into pingcap:release-4.0 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants