Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function (#16014) #16559

Merged
merged 8 commits into from
Apr 30, 2020
Merged

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function (#16014) #16559

merged 8 commits into from
Apr 30, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 17, 2020

cherry-pick #16014 to release-4.0

What problem does this PR solve?

Issue Number: close #15986

What is changed and how it works?

When we use the string type to determine the bool value, the string type is converted to a float type instead of an int type.

Check List

Tests

  • Unit test
  • Integration test

@sre-bot sre-bot requested a review from a team as a code owner April 17, 2020 14:47
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 17, 2020
Merged
@sre-bot sre-bot added this to the v4.0.0-rc.1 milestone Apr 17, 2020
@Reminiscent
Copy link
Contributor

wait for (tikv#7548)(tikv/tikv#7548)

@Reminiscent
Copy link
Contributor

/run-all-tests

@wshwsh12 wshwsh12 mentioned this pull request Apr 22, 2020
Merged
zz-jason
zz-jason reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2020
SunRunAway
SunRunAway approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 23, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

Your auto merge job has been accepted, waiting for:

  • 16739
  • 15905
  • 16714

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

@sre-bot merge failed.

@breezewish
Copy link
Member

/run-integration-copr-test

1 similar comment
@breezewish
Copy link
Member

/run-integration-copr-test

@Reminiscent
Copy link
Contributor

/run-all-tests

@breezewish
Copy link
Member

/run-all-tests

@breezewish
Copy link
Member

/run-integration-copr-test tikv=pr/7548

@zhongzc
Copy link
Contributor

zhongzc commented Apr 24, 2020

/run-integration-copr-test tikv=pr/7548

1 similar comment
@zhongzc
Copy link
Contributor

zhongzc commented Apr 25, 2020

/run-integration-copr-test tikv=pr/7548

@zhongzc
Copy link
Contributor

zhongzc commented Apr 25, 2020

/run-all-tests tikv=pr/7548

@zhongzc
Copy link
Contributor

zhongzc commented Apr 25, 2020

/run-all-tests tikv=pr/7548

@Reminiscent
Copy link
Contributor

wait for #16446 cherry pick

@crazycs520 crazycs520 modified the milestones: v4.0.0-rc.2, v4.0.0-rc.1 Apr 26, 2020
@Reminiscent
Copy link
Contributor

/run-all-tests

@qw4990 qw4990 removed their request for review April 28, 2020 08:38
@Reminiscent
Copy link
Contributor

/run-all-tests tikv=pr/7548

@breezewish
Copy link
Member

/run-all-tests

@SunRunAway
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 30, 2020

Your auto merge job has been accepted, waiting for:

  • 16952

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 30, 2020

/run-all-tests

@sre-bot sre-bot merged commit 74b63e2 into pingcap:release-4.0 Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

Assignees

@Reminiscent Reminiscent

Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
8 participants
@sre-bot @Reminiscent @breezewish @zhongzc @SunRunAway @zz-jason @crazycs520 @wshwsh12