Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: resolve data race #14610

Merged
merged 3 commits into from
Feb 4, 2020
Merged

util: resolve data race #14610

merged 3 commits into from
Feb 4, 2020

Conversation

hsqlu
Copy link
Contributor

@hsqlu hsqlu commented Feb 3, 2020

What problem does this PR solve?

#14419

What is changed and how it works?

change to using atomic.LoadInt64() to obtain the CommitBackoffTime.

Check List

Tests

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Feb 3, 2020
crazycs520
crazycs520 reviewed Feb 4, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@crazycs520 crazycs520 added component/test status/LGT1 Indicates that a PR has LGTM 1. labels Feb 4, 2020
ngaut
ngaut approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 4, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 4, 2020

/run-all-tests

@sre-bot sre-bot merged commit 7720d7d into pingcap:master Feb 4, 2020
@hsqlu hsqlu deleted the util-data-race branch February 4, 2020 23:06
hsqlu added a commit to hsqlu/tidb that referenced this pull request Feb 8, 2020
@hsqlu
util: resolve data race (pingcap#14610)
53c2eb1
@djshow832
Copy link
Contributor

/run-cherry-picker

@sre-bot sre-bot mentioned this pull request Feb 13, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Feb 13, 2020

cherry pick to release-3.0 in PR #14778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
component/test contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hsqlu @sre-bot @djshow832 @ngaut @crazycs520