util: resolve data race (#14610)

pingcap · Feb 4, 2020 · 7720d7d · 7720d7d
1 parent 2192448
commit 7720d7d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/util/stmtsummary/statement_summary.go b/util/stmtsummary/statement_summary.go
@@ -727,9 +727,10 @@ func (ssElement *stmtSummaryByDigestElement) add(sei *StmtExecInfo, intervalSeco
 		if commitDetails.GetCommitTsTime > ssElement.maxGetCommitTsTime {
 			ssElement.maxGetCommitTsTime = commitDetails.GetCommitTsTime
 		}
-		ssElement.sumCommitBackoffTime += commitDetails.CommitBackoffTime
-		if commitDetails.CommitBackoffTime > ssElement.maxCommitBackoffTime {
-			ssElement.maxCommitBackoffTime = commitDetails.CommitBackoffTime
+		commitBackoffTime := atomic.LoadInt64(&commitDetails.CommitBackoffTime)
+		ssElement.sumCommitBackoffTime += commitBackoffTime
+		if commitBackoffTime > ssElement.maxCommitBackoffTime {
+			ssElement.maxCommitBackoffTime = commitBackoffTime
 		}
 		resolveLockTime := atomic.LoadInt64(&commitDetails.ResolveLockTime)
 		ssElement.sumResolveLockTime += resolveLockTime