Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: resolve data race (#14610) #14778

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Feb 13, 2020

cherry-pick #14610 to release-3.0


What problem does this PR solve?

#14419

What is changed and how it works?

change to using atomic.LoadInt64() to obtain the CommitBackoffTime.

Check List

Tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 13, 2020

/run-all-tests

@sre-bot sre-bot added component/test contribution This PR is from a community contributor. type/3.0 cherry-pick labels Feb 13, 2020
@djshow832 djshow832 requested review from lonng and removed request for ngaut February 13, 2020 09:13
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Deardrops Deardrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djshow832
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Feb 13, 2020

Sorry @djshow832, you don't have permission to trigger auto merge event on this branch.

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit 3c135e5 into pingcap:release-3.0 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test contribution This PR is from a community contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants